-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Extend minicore with intrinsics and use it to replace #[rustc_intrinsic] in tests #140037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Hanif Ariffin <[email protected]>
rustbot has assigned @Mark-Simulacrum. Use |
I am getting this issue
From what I can gather, the problem is that the compiler optimizes out the function? |
The job Click to see the possible cause of the failure (guessed by this bot)
|
Not quite. From what I can tell, the key instructions are still present (i.e. if you comment out the E.g. loongarch64 revision (this PR) issue_114508_u32:
sltu $a2, $a1, $a0
masknez $a1, $a1, $a2
maskeqz $a0, $a0, $a2
or $a0, $a0, $a1
ret
.Lfunc_end0:
.size issue_114508_u32, .Lfunc_end0-issue_114508_u32
.section .text.issue_114508_i32,"ax",@progbits
.globl issue_114508_i32
.p2align 5
.type issue_114508_i32,@function
issue_114508_i32:
slt $a2, $a1, $a0
masknez $a1, $a1, $a2
maskeqz $a0, $a0, $a2
or $a0, $a0, $a1
ret
.Lfunc_end1:
.size issue_114508_i32, .Lfunc_end1-issue_114508_i32
.ident "rustc version 1.88.0-dev"
.section ".note.GNU-stack","",@progbits on issue_114508_u32:
.cfi_startproc
sltu $a2, $a1, $a0
masknez $a1, $a1, $a2
maskeqz $a0, $a0, $a2
or $a0, $a0, $a1
ret
.Lfunc_end0:
.size issue_114508_u32, .Lfunc_end0-issue_114508_u32
.cfi_endproc
.section .text.issue_114508_i32,"ax",@progbits
.globl issue_114508_i32
.p2align 5
.type issue_114508_i32,@function
issue_114508_i32:
.cfi_startproc
slt $a2, $a1, $a0
masknez $a1, $a1, $a2
maskeqz $a0, $a0, $a2
or $a0, $a0, $a1
ret
.Lfunc_end1:
.size issue_114508_i32, .Lfunc_end1-issue_114508_i32
.cfi_endproc
.ident "rustc version 1.88.0-dev"
.section ".note.GNU-stack","",@progbits cc @rcvalle do you happen to know why the CFI directives might be missing? FWIW, minicore is built as an rlib + |
Fixes #139918